-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom name of the manifest when syncing and publishing #115
Conversation
There's a problem in entering manifest param to the publish request. Example:
The cause of the problem is here: pulp_file/pulp_file/app/viewsets.py Line 133 in 3fdb37c
Manifest doesn't pass through serializer validation. It's not part of the model. Is there another way how to get data from command line in the viewset? |
Update: I didn't notice that there is a suggested solution in issues/3913. So name of the manifest is passed as a field of the publisher. |
Storing a field on the FilePublisher seems better to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. I think you'll need to update the sync smash tests though.
👍 adding a |
Cool, thanks, so I'll update the tests and |
When creating a remote user can specify his own name of the manifest. As a path to it will be used url/manifest. For example: $ http POST .../remotes/file/ name=rem1 url=https://repos.fedorapeople.org/pulp/pulp/demo_repos/test_file_repo/ manifest=PULP_MANIFEST Same situation when creating a publisher. For example: $ http POST .../publishers/file/ name=publisher1 manifest=my_manifest.csv closes #3912, #3913 https://pulp.plan.io/issues/3912 https://pulp.plan.io/issues/3913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @vdusek.
When creating a remote user can specify his own name of the manifest.
As a path to it will be used url/manifest. For example:
Same situation when creating a publisher.
For example:
closes #3912, #3913
https://pulp.plan.io/issues/3912
https://pulp.plan.io/issues/3913