Allow custom name of the manifest when syncing and publishing

[vdusek]

When creating a remote user can specify his own name of the manifest.
As a path to it will be used url/manifest. For example:

$ http POST .../remotes/file/ 
    name=rem1 
    url=https://repos.fedorapeople.org/pulp/pulp/demo_repos/test_file_repo/
    manifest=PULP_MANIFEST

Same situation when creating a publisher.
For example:

$ http POST .../publishers/file/ 
    name=publisher1 
    manifest=my_manifest.csv

closes #3912, #3913
https://pulp.plan.io/issues/3912
https://pulp.plan.io/issues/3913

[vdusek]

There's a problem in entering manifest param to the publish request. Example:

$ http POST $PUBLISHER_HREF'publish/' repository=$REPO_HREF manifest='my_manifest.csv'

...
{
    "manifest": [
        "Unexpected field"
    ]
}

The cause of the problem is here:

pulp_file/pulp_file/app/viewsets.py

Line 133 in 3fdb37c

manifest = serializer.validated_data.get('manifest', 'manifest.csv')

Manifest doesn't pass through serializer validation. It's not part of the model. Is there another way how to get data from command line in the viewset?

[vdusek]

Update: I didn't notice that there is a suggested solution in issues/3913. So name of the manifest is passed as a field of the publisher.

[daviddavis]

I guess the two options regarding publish:

1. Store a manifest field on the FilePublisher model
2. Add a manifest parameter to the publish endpoint (e.g. http POST ':8000'$PUBLISHER_HREF'publish/' repository=$REPO_HREF manifest=PULP_MANIFEST)

cc @jortel and @dkliban — any thoughts?

[dkliban]

Storing a field on the FilePublisher seems better to me.

[daviddavis]

Code looks good to me. I think you'll need to update the sync smash tests though.

[jortel]

👍 adding a manifest field to FilePublisher.

[vdusek]

Cool, thanks, so I'll update the tests and README.rst.

[jortel]

Thanks for the contribution, @vdusek.