Changing relative_path and digest to CharFields #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
issue4288
branch
2 times, most recently
from
1e70af2
to
6f36d5b
Compare
daviddavis
changed the title
The relative_path and digest fields are text fields and are part of a unique constraint which MySQL/mariadb doesn't support. ref #4288 https://pulp.plan.io/issues/4288
daviddavis
force-pushed
the
issue4288
branch
from
6f36d5b
to
83d8644
Compare
bmbouter
approved these changes
Feb 25, 2019
dralley
reviewed
Feb 26, 2019
| relative_path = models.TextField(null=False) | ||
| digest = models.TextField(null=False) | ||
| relative_path = models.CharField(max_length=255, null=False) | ||
| digest = models.CharField(max_length=255, null=False) |
There was a problem hiding this comment.
If "digest" is expected to always be a sha256, we can just use 64, the length of a sha256 hash.
Also I'm sure 255 chars is more than relative_path will typically need but we may want to document that limitation, and maybe try to think if it could ever be violated.
There was a problem hiding this comment.
I opened a PR for the digest change and an issue to discuss the relative_path problem.
PR: #191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative_path and digest fields are text fields and are used in a constraint which MySQL doesn't
support.