Rename artifact to _artifact #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelpicka
added a commit
to pavelpicka/pulp
that referenced
this pull request
Jan 24, 2019
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. Fix for testing. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp_file#158 Signed-off-by: Pavel Picka <ppicka@redhat.com>
daviddavis
approved these changes
Jan 24, 2019
|
Travis is not going to pass because you need the full PR url. You have Let me know when you've fixed it and I can merge. |
pavelpicka
added a commit
to pavelpicka/pulp
that referenced
this pull request
Jan 28, 2019
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. Fix for testing. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp_file#158 Signed-off-by: Pavel Picka <ppicka@redhat.com>
pavelpicka
added a commit
to pavelpicka/pulp
that referenced
this pull request
Jan 28, 2019
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. Fix for testing. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp_file#158 Required PR: pulp/pulp-smash#1164 Signed-off-by: Pavel Picka <ppicka@redhat.com>
pavelpicka
added a commit
to pavelpicka/pulp
that referenced
this pull request
Jan 28, 2019
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. Fix for testing. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp_file#158 Required PR: pulp/pulp-smash#1164 Signed-off-by: Pavel Picka <ppicka@redhat.com>
pavelpicka
added a commit
to pavelpicka/pulp
that referenced
this pull request
Jan 28, 2019
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. Fix for testing. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp_file#158 Required PR: pulp/pulp-smash#1164 Signed-off-by: Pavel Picka <ppicka@redhat.com>
Renaming to '_artifact' to be clearer that artifact is part of pulpcore. as continue for #4206 refactor. re: #4282 https://pulp.plan.io/issues/4282 Required PR: pulp/pulp#3843 Required PR: pulp/pulp-smash#1164 Signed-off-by: Pavel Picka <ppicka@redhat.com>
|
I'm really sorry! This PR is going to be superceded by a new story which fixes this in a different / more permanent way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming to '_artifact' to be clearer that artifact
is part of pulpcore. as continue for #4206 refactor.
re: #4282
https://pulp.plan.io/issues/4282
Required PR: pulp/pulp#3843
Required PR: pulp/pulp-smash#1164
Signed-off-by: Pavel Picka ppicka@redhat.com