Adding checksums to file attributes #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
issue4827
branch
2 times, most recently
from
dd8f4bb
to
721e755
Compare
dralley
reviewed
May 23, 2019
pulp_file/app/viewsets.py
Outdated
| @@ -46,7 +46,7 @@ class FileContentViewSet(ContentViewSet): | |||
| """ | |||
|
|
|||
| endpoint_name = 'files' | |||
| queryset = FileContent.objects.all() | |||
| queryset = FileContent.objects.prefetch_related("_artifacts").all() | |||
There was a problem hiding this comment.
Should it be the other way around?
FileContent.objects.all().prefetch_related("_artifacts")
There was a problem hiding this comment.
I tested it and couldn't detect a difference. I shortened it to FileContent.objects.prefetch_related("_artifacts") to avoid confusion and to make it simpler. Let me know if you disagree with that.
fixes #4827 https://pulp.plan.io/issues/4827 Required PR: pulp/pulpcore#150 Required PR: pulp/pulpcore-plugin#102
dralley
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4827
https://pulp.plan.io/issues/4827