Refactor Exporter models based on pulpcore changes #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 16, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 16, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 16, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 16, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
force-pushed
the
issue6328
branch
2 times, most recently
from
9956c03
to
755a3c4
Compare
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 16, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 16, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 16, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 16, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 17, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
force-pushed
the
issue6328
branch
2 times, most recently
from
e62011f
to
8e20fde
Compare
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 17, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 18, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
force-pushed
the
issue6328
branch
2 times, most recently
from
0cc9d0a
to
17898bc
Compare
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 19, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 19, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 23, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
bmbouter
reviewed
Mar 24, 2020
bmbouter
reviewed
Mar 24, 2020
| """ | ||
| FileSystemExporters export content from a publication to a path on the file system. | ||
|
|
||
| WARNING: This feature is provided as a tech preview and may change in the future. Backwards | ||
| compatibility is not guaranteed. | ||
| """ | ||
|
|
||
| endpoint_name = "file" | ||
| endpoint_name = "filesystem" |
bmbouter
reviewed
Mar 24, 2020
|
Attached issue: https://pulp.plan.io/issues/6328 |
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 24, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Mar 24, 2020
Also adding a new Export model and refactoring existing Exporters. fixes #6328 https://pulp.plan.io/issues/6328 Required PR: pulp/pulp_file#366
daviddavis
force-pushed
the
issue6328
branch
2 times, most recently
from
b764f38
to
4b5400f
Compare
bmbouter
reviewed
Mar 24, 2020
bmbouter
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
@daviddavis thank you! I left one last optional comment on the 6328.removal file. Handle as you like I'm lgtm-ing now. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6328
https://pulp.plan.io/issues/6328
Required PR: pulp/pulpcore#585