Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase FileContentResource to subclass from BaseContentResource #406

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

ggainey
Copy link
Contributor

@ggainey ggainey commented Jun 6, 2020

ref #6807
Required PR: pulp/pulpcore#745

@pulpbot
Copy link
Member

pulpbot commented Jun 6, 2020

Attached issue: https://pulp.plan.io/issues/6807

ggainey added a commit to ggainey/pulpcore that referenced this pull request Jun 6, 2020
Dealing this required slimming down the fields we export/import,
so #6515 got addressed along the way as well.

Required PR: pulp/pulp_file#406
closes #6807
closes #6515
@ggainey ggainey force-pushed the natural_keys_POC branch 5 times, most recently from d9f68ea to d5bd9c8 Compare June 9, 2020 13:33
ggainey added a commit to ggainey/pulpcore that referenced this pull request Jun 9, 2020
Dealing this required slimming down the fields we export/import,
so #6515 got addressed along the way as well.

Required PR: pulp/pulp_file#406
closes #6807
closes #6515
ggainey added a commit to ggainey/pulpcore that referenced this pull request Jul 10, 2020
Dealing this required slimming down the fields we export/import,
so #6515 got addressed along the way as well.

Required PR: pulp/pulp_file#406
closes #6807
closes #6515
ggainey added a commit to ggainey/pulpcore that referenced this pull request Jul 14, 2020
Dealing this required slimming down the fields we export/import,
so #6515 got addressed along the way as well.

Required PR: pulp/pulp_file#406
closes #6807
closes #6515
ggainey added a commit to ggainey/pulpcore that referenced this pull request Jul 14, 2020
Dealing this required slimming down the fields we export/import,
so #6515 got addressed along the way as well.

Required PR: pulp/pulp_file#406
closes #6807
closes #6515
ggainey added a commit to ggainey/pulpcore that referenced this pull request Jul 14, 2020
Dealing this required slimming down the fields we export/import,
so #6515 got addressed along the way as well.

Required PR: pulp/pulp_file#406
closes #6807
closes #6515
Copy link
Contributor

@daviddavis daviddavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Other than that, LGTM.

CHANGES/6936.bugfix Outdated Show resolved Hide resolved
@daviddavis daviddavis merged commit 9835a4c into pulp:master Jul 14, 2020
daviddavis pushed a commit to pulp/pulpcore that referenced this pull request Jul 14, 2020
Dealing this required slimming down the fields we export/import,
so #6515 got addressed along the way as well.

Required PR: pulp/pulp_file#406
closes #6807
closes #6515
@ggainey ggainey deleted the natural_keys_POC branch July 18, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants