Require tests for feature/bugfix #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7437 |
fao89
force-pushed
the
7437
branch
2 times, most recently
from
efc78f2
to
fbd286b
Compare
mdellweg
reviewed
Sep 9, 2020
Comment on lines
+24
to
+18
| REQUIRES_TEST=$(git diff --name-only $RANGE | grep -E 'feature|bugfix') | ||
| CONTAINS_TEST=$(git diff --name-only $RANGE | grep -E '^test_') |
There was a problem hiding this comment.
I think we should be testing this for each commit in the PR separately (Neccessary requirement for proper cherry-picking). Also i wished, this could deliver a warning instead of a failure, as it is a bit fuzzy by nature... (But that will remain a wish with current CI providers.).
Also I liked the first grep to be specific about files being in "/CHANGES", and maybe the second one expecting a comment like tests #1234 within the /pulp_file/tests directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/7437
closes #7437