implement master/detail tasks #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using DRF to create tasks, we can rely on the serializer validation rather than doing it with the viewset.
asmacdo
commented
Mar 23, 2018
|
|
||
|
|
||
| log = getLogger(__name__) | ||
|
|
||
|
|
||
| class FileTask(Task): |
There was a problem hiding this comment.
This isn't a real type of task. It just allows the plugin writers to view v3/tasks/file/ that include all of them (sync, publish, etc). This type of task won't ever be created because the FileTaskViewSet does not have the create mixin.
asmacdo
commented
Mar 23, 2018
| queryset=Repository.objects.all(), | ||
| ) | ||
|
|
||
| reservation_structure = ["repository", "importer"] |
There was a problem hiding this comment.
Used by pulpcore to create reserved tasks.
asmacdo
commented
Mar 23, 2018
| reservation_structure = ["repository", "importer"] | ||
| task_kwarg_structure = {'importer_pk': "importer.pk", | ||
| 'repository_pk': "repository.pk"} | ||
| celery_task = tasks.synchronize |
There was a problem hiding this comment.
This can deploy plugin defined tasks like it does here, or it could deploy core defined tasks. Add/Remove seems like a good candidate for a core defined task that would work for some simple plugins.
|
Closing for now, this branch has gotten really out of date. I'll reopen if it becomes relevant for discussion again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.