Reduce test assumptions #678
Merged
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_acs_sync` needs to have orphans cleaned prior, but since it was the first test typically it didn't show this problem before. Also we shouldn't need to cleanup orphans after that test anymore either. By not cleaning up orphans we now have to clean up orphans prior to at least one other test. Also the test_auto_publish test had assumptions that content was already available in the system so that test got rewritten some. [noissue]
bmbouter
force-pushed
the
make-tests-more-resilient
branch
from
d0b043b
to
734f316
Compare
ipanova
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_acs_syncneeds to have orphans cleaned prior, but since itwas the first test typically it didn't show this problem before. Also we
shouldn't need to cleanup orphans after that test anymore either.
By not cleaning up orphans we now have to clean up orphans prior to at
least one other test. Also the test_auto_publish test had assumptions
that content was already available in the system so that test got
rewritten some.
[noissue]