Add tests from pulpcore #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bmbouter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-04-18 20:24:44 UTC |
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Apr 18, 2022
Required PR: pulp/pulp_file#685 [noissue]
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Apr 18, 2022
Required PR: pulp/pulp_file#685 [noissue]
bmbouter
force-pushed
the
add-pulpcore-tests-to-pulp_file
branch
2 times, most recently
from
f5347ec
to
abbb8d6
Compare
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Apr 18, 2022
Required PR: pulp/pulp_file#685 [noissue]
bmbouter
force-pushed
the
add-pulpcore-tests-to-pulp_file
branch
from
abbb8d6
to
ac26126
Compare
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Apr 18, 2022
Required PR: pulp/pulp_file#685 [noissue]
bmbouter
force-pushed
the
add-pulpcore-tests-to-pulp_file
branch
2 times, most recently
from
497b9d5
to
d27e3d5
Compare
Required PR: pulp/pulpcore#2535 [noissue]
bmbouter
force-pushed
the
add-pulpcore-tests-to-pulp_file
branch
from
d27e3d5
to
737fbdb
Compare
bmbouter
added a commit
to bmbouter/pulpcore
that referenced
this pull request
Apr 18, 2022
Required PR: pulp/pulp_file#685 [noissue]
mdellweg
reviewed
Apr 19, 2022
There was a problem hiding this comment.
Let me understand the directory name from_pulpcore. I think it describes the history of that files. But that is no useful information here. Do you intend to move the tests out of this directory while transforming them to using pytest? Or should we name it with_pulpcore or simply pulpcore to signify that we test pulpcore instead of pulp_file in that directory?
| @@ -7,4 +7,4 @@ include COPYRIGHT | |||
| include functest_requirements.txt | |||
| include test_requirements.txt | |||
| include unittest_requirements.txt | |||
| recursive-exclude pulp_file/tests/fixtures/ * | |||
| recursive-exclude pulp_file/tests/functional * | |||
fao89
approved these changes
Apr 19, 2022
mdellweg
approved these changes
Apr 19, 2022
bmbouter
added a commit
to pulp/pulpcore
that referenced
this pull request
Apr 19, 2022
Required PR: pulp/pulp_file#685 [noissue]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required PR: pulp/pulpcore#2535
[noissue]