Add pull-through caching support #97
Conversation
gerrod3
force-pushed
the
pull-through
branch
2 times, most recently
from
86993af
to
b43a5ee
Compare
gerrod3
force-pushed
the
pull-through
branch
2 times, most recently
from
0283528
to
a0ff316
Compare
| pytest.skip("gem not installed on test machine") | ||
| content_before = gem_content_api_client.list().count | ||
|
|
||
| remote = gem_remote_factory(url="https://rubygems.org") |
There was a problem hiding this comment.
Where's the repository to receive all the cached content?
There was a problem hiding this comment.
You don't need it. Pulp itself is the repository that is storing the cached content. An admin user would need to list the content and manually add it to a repository if they want to.
We could add a feature request in pulpcore to try to add the pull-through content to an attached repository.
There was a problem hiding this comment.
So the caching is actually only done until someone calls orphan cleanup.
Yes, I think we should handle the case when a pull-through distribution has a repository and a remote. You could use that e.g. to collect all the packages needed to build one container and then move it into an immutable set.
fixes: #94
Required pulpcore: pulp/pulpcore#3819
TODO: