Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Adds the PULP_SETTINGS Env Var #182

Merged
merged 1 commit into from Oct 17, 2019

Conversation

mikedep333
Copy link
Member

Sets it in:

  • systemd units
  • pulp-devel role bash script
  • Any task/handler that calls django-admin

https://pulp.plan.io/issues/5560
closes #5560

This PR replaces: #181

Sets it in:
- systemd units
- pulp-devel role bash script
- Any task/handler that calls django-admin

https://pulp.plan.io/issues/5560
closes #5560
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I can see how it addresses all the needs. I'm also testing it locally now.

@mikedep333
Copy link
Member Author

@bmbouter Yeah, it worked for me with pulplift with the source scenario, including after running workon pulp.

@bmbouter
Copy link
Member

@mikedep333 this also fully worked for me!

bmbouter added a commit to bmbouter/pulpcore that referenced this pull request Oct 17, 2019
This changes Pulp to not assume any settings file is needed or looked
for at all. It encourages the user to set one via the `PULP_SETTINGS`
Environment Variable. The settings documentation was updated to reflect
this.

The Installer will continue working as is. The PR below causes the
installer to set `PULP_SETTINGS` correctly allowing settings to work
the same way in those environments.

Required PR: pulp/pulp_installer#182

https://pulp.plan.io/issues/5560
closes #5560
@mikedep333 mikedep333 merged commit 0f0c084 into pulp:master Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants