This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
pulp_redis: Allow to configure Unix Domain Socket #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attached issue: https://pulp.plan.io/issues/6931 |
This tested has been tested with the following two scenarios: Scenario 1: Using Unix Domain Socket
Scenario 2: Using the defaults value for pulp_redis_bind 127.0.0.1:6379
Both have deployed successfully, and the following can be observed in
|
fao89
approved these changes
Jun 9, 2020
Comment on lines
+7
to
+17
- name: Ensure Redis will listen on the specified TCP socket | ||
lineinfile: | ||
path: '{{ pulp_redis_conf_file }}' | ||
regexp: '{{ item.regexp }}' | ||
line: '{{ item.line }}' | ||
loop: | ||
- regexp: '^port ' | ||
line: 'port {{ pulp_redis_port }}' | ||
- regexp: '^bind ' | ||
line: 'bind {{ pulp_redis_host }}' | ||
notify: restart redis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Comment on lines
+6
to
+12
- name: Ensure pulp is part of group redis | ||
user: | ||
name: '{{ pulp_user }}' | ||
groups: redis | ||
append: true | ||
|
||
- name: Ensure Redis will not listen on a TCP socket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked these ensure tasks
bmbouter
reviewed
Jun 9, 2020
mikedep333
suggested changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! See 1 suggestion.
This commit ensures one can configure redis so it listens to unix domain socket (if wanted) rather than forcing it to listen on TCP socket. Benefits of this commit has been higlighted in previous PR[1]. Also, this commit introduces `pulp_redis_bind` to offer an expected experience for people using `pulp/pulp_installer` when it comes to configure network services (ie. `pulp_api_bind`, `pulp_content_bind`). fixes #6931 [1] pulp#322
mikedep333
approved these changes
Jun 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures one can configure redis so it listens to unix domain
socket (if wanted) rather than forcing it to listen on TCP socket.
Benefits of this commit has been higlighted in previous PR[1].
Also, this commit introduces
pulp_redis_bind
to offer an expectedexperience for people using
pulp/pulp_installer
when it comes toconfigure network services (ie.
pulp_api_bind
,pulp_content_bind
).fixes #6931
[1] #322