This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Drop hardcoded Redis dependency #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6975 |
In order to embrace a Service Oriented Architecture, where things like Postgres and Redis could be run anywhere (localhost, other machine on the network, SaaS offering) having an hardcoded requirement on those services to be installed along side pulp services ian'r oprimal. With this commit, if one wants to install Redis, onc would need to explicitly list it in the role list one wants installed. But if one wants to use a SaaS offering, simply specifying `redis_host` or `redis_url` would work - without installing or running extra software on the server. fixes #6975
Spredzy
added a commit
to Spredzy/galaxy_ng
that referenced
this pull request
Jun 17, 2020
Earlier today in `pulp/pulp_installer` pulp/pulp_installer#332 got merged. This leads to one having to specify the pulp_redis role explicitly.
Spredzy
added a commit
to Spredzy/galaxy_ng
that referenced
this pull request
Jun 17, 2020
Earlier today in `pulp/pulp_installer` pulp/pulp_installer#332 got merged. This leads to one having to specify the pulp_redis role explicitly.
chouseknecht
pushed a commit
to ansible/galaxy_ng
that referenced
this pull request
Jun 18, 2020
Earlier today in `pulp/pulp_installer` pulp/pulp_installer#332 got merged. This leads to one having to specify the pulp_redis role explicitly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to embrace a Service Oriented Architecture, where things like
Postgres and Redis could be run anywhere (localhost, other machine on
the network, SaaS offering) having an hardcoded requirement on those
services to be installed along side pulp services ian'r oprimal.
With this commit, if one wants to install Redis, onc would need to
explicitly list it in the role list one wants installed. But if one
wants to use a SaaS offering, simply specifying
redis_hostorredis_urlwould work - without installing or running extra software onthe server.
fixes #6975