problem: pulp_installer source-upgrade CI is failing #434
Conversation
|
Attached issue: https://pulp.plan.io/issues/7503 |
mikedep333
force-pushed
the
dynaconf-box-fix-with-prerelease
branch
from
21a2832
to
afa6e47
Compare
| # box. | ||
| - name: Upgrade dynaconf to 3.1.1rc1 pre-release if it is older than 3.1.1 | ||
| pip: | ||
| name: dynaconf==3.1.1rc1 |
There was a problem hiding this comment.
the pre-release is failing:
https://travis-ci.com/github/fao89/pulpcore/jobs/384721721#L922
There was a problem hiding this comment.
I think it should be >= instead of ==
There was a problem hiding this comment.
Yes, but I think it will install future pre-release versions indefinitely as well if I do that:
https://pip.pypa.io/en/stable/reference/pip_install/#pre-release-versions
due to an issue between dynaconf and box. That test includes an upgrade from pulpcore 3.0. Solution: Upgrade dynaconf to at least 3.1.1rc2 pre-release. fixes: #7503
mikedep333
force-pushed
the
dynaconf-box-fix-with-prerelease
branch
from
afa6e47
to
9ecec1e
Compare
| state: present | ||
| virtualenv: '{{ pulp_install_dir }}' | ||
| virtualenv_command: '{{ pulp_python_interpreter }} -m venv' | ||
| when: pip_pkgs.packages[pulp_install_dir + '/bin/pip'].dynaconf[0].version is version("3.1.1", "<") |
There was a problem hiding this comment.
I just noticed it now, I didn't know about this version plugin.
Nice!
There was a problem hiding this comment.
Yeah, the ansible docs are quite explicit that you should use it to safely compare versions. A simple numerical operator is unlikely to compare 3.3.3 to 3.3 successfully, the former has 2 dots and is therefore not a float. Or 3.10 to 3.1 .
https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#version-comparison
due to an issue between dynaconf and box. That test includes
an upgrade from pulpcore 3.0.
Solution: Upgrade dynaconf to at least 3.1.1rc2 pre-release.
fixes: #7503