This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Add requirements, clarify variable usage #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/8477 |
melcorr
force-pushed
the
part-one-doc-cleanup
branch
3 times, most recently
from
6f09361
to
9af8dcf
Compare
fixes #8477
melcorr
force-pushed
the
part-one-doc-cleanup
branch
from
9af8dcf
to
b49b958
Compare
fao89
approved these changes
Apr 12, 2021
Comment on lines
+13
to
+17
| **Didn't find what you need to get started?** | ||
|
|
||
| We are actively trying to make our documentation as complete and user-friendly as possible. | ||
| If you experience any difficulties or have any feedback, write to `pulp-list@redhat.com`. | ||
| [Documentation PRs](https://github.com/pulp/pulp_installer/edit/master/docs/index.md) are always welcome. |
There was a problem hiding this comment.
I think we need something similar at the README, since the README goes to galaxy:
https://galaxy.ansible.com/pulp/pulp_installer
| @@ -27,16 +40,18 @@ exception is Pulp 2. The RESP APIs for Pulp 2 and Pulp 3 can be served on the sa | |||
| long as the `apache` webserver is deployed for both. | |||
|
|
|||
| The Ansible collection requires [geerlingguy.postgresql](https://galaxy.ansible.com/geerlingguy/postgresql) role, | |||
| which should be installed from ansible-galaxy. | |||
| which you can from ansible-galaxy. | |||
There was a problem hiding this comment.
Suggested change
| which you can from ansible-galaxy. | |
| which you can install from ansible-galaxy. |
|
Actually, I'm gonna merge it and do a follow-up PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8477
Adding links to requirements and clarifying the Ansible variables section.
Trying to kickstart the docs revamp.
With your blessing, in another PR, I would like to merge the index.md and quickstart into a complete flow or relevant tasks.