pulpcore-plugin 0.1.0rc4 compatibility #15
Conversation
dkliban
force-pushed
the
beta3
branch
9 times, most recently
from
0b80c25
to
06e06fa
Compare
Solution: use plugin-template to update travis config The code is now also formatted with black. Migrations are committed. closes: #5217 https://pulp.plan.io/issues/5217
| # bootstrap.py to update this file. | ||
| # | ||
| # For more info visit https://github.com/pulp/plugin_template | ||
|
|
There was a problem hiding this comment.
Is this file still needed? mariadb.yml
.travis/publish_plugin_pypi.sh
Outdated
| pip install twine | ||
|
|
||
| python setup.py sdist bdist_wheel --python-tag py3 | ||
| twine upload dist/* -u pulp -p $PYPI_PASSWORD | ||
| twine upload dist/* -u None -p $PYPI_PASSWORD |
There was a problem hiding this comment.
Why is username changed to None?
| sync | ||
| upload | ||
| publish-host | ||
| cache |
There was a problem hiding this comment.
why did you keep only cache use case?
There was a problem hiding this comment.
Because there is only one workflow right now. It's the cache one.
template_config.yml
Outdated
| docs_test: True | ||
| pydocstyle: True | ||
| test_bindings: False | ||
| pypi_username: None |
There was a problem hiding this comment.
Is it correct that the username is None?
There was a problem hiding this comment.
No, I need to correct this.
| @@ -0,0 +1 @@ | |||
| Updates serializers and tests to make plugin compatible with pulpcore-plugin 0.1.0rc4. | |||
There was a problem hiding this comment.
How about a .feature about adding towncrier? Just a suggestion.
| @@ -0,0 +1 @@ | |||
| Updates serializers and tests to make plugin compatible with pulpcore-plugin 0.1.0rc4. | |||
There was a problem hiding this comment.
I'm not sure what was incompatible with pulpcore, except for tests.
I didn't notice any changes in serializer (maybe black changes make it hard to notice).
Solution: add towncrier [noissue]
This PR adds compatibility with pulpcore-plugin 0.1.0rc4, introduces black formatting, and introduces towncrier for changes.