1145719 - Puppet directory import now respects the 'remove_missing' configuration setting #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.report.modules_total_count -= 1 | ||
| continue | ||
| _LOG.info(IMPORT_MODULE % dict(mod=module_path)) | ||
| imported_modules.append(module.unit_key()) | ||
| _LOG.debug(IMPORT_MODULE % dict(mod=module_path)) |
There was a problem hiding this comment.
I personally felt that info logging every module import was a bit too noisy, but I'd like to know what others think.
There was a problem hiding this comment.
On 11/25/2014 04:29 PM, Jeremy Cline wrote:
I personally felt that info logging every module import was a bit too
noisy, but I'd like to know what others think.
I agree.
|
|
||
| # Even though we've already basically processed this unit, not doing this makes the | ||
| # progress reporting confusing because it shows Pulp always importing all the modules. | ||
| if module.unit_key() in [unit.unit_key for unit in local_units]: |
There was a problem hiding this comment.
You should move this list comprehension to be outside the loop so that it doesn't happen for each unit.
|
Can you add one more test to assert that remove_missing gets called by call() when it's supposed to be? LGTM. |
…onfiguration setting.
jeremycline
added a commit
that referenced
this pull request
Dec 10, 2014
1145719 - Puppet directory import now respects the 'remove_missing' configuration setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1145719