Updates metadata.json search to look in first top-level folder #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Attempt to find the metadata in the first folder of the tar.gz | ||
| module_dir = os.listdir(extraction_dir)[0] | ||
| metadata_filename = constants.MODULE_METADATA_FILENAME | ||
| metadata_full_path = os.sep.join([extraction_dir, module_dir, metadata_filename]) |
There was a problem hiding this comment.
How about os.path.join instead? I've never used os.sep directly, but I see that its documentation recommends using os.path.join.
There was a problem hiding this comment.
os.path.join is better, I updated it for that.
bmbouter
force-pushed
the
890-pumpkin
branch
3 times, most recently
from
5c98f3d
to
89762c9
Compare
The implementation was using a depth-first-search which did not traverse in the same order on all platforms. Some Puppet modules contain other modules as dependencies, and the DFS implementation could incorrectly find the wrong one. This uses a very dumb approach which looks for metadata.json in the top level folder of the the tar.gz uploaded Puppet module. This is based on the Puppet packaging guidelines [0]. [0]: https://docs.puppetlabs.com/puppet/latest/reference/modules_fundamentals.html#module-fundamentals https://pulp.plan.io/issues/890 closes #890
|
Refer to this link for build results (access rights to CI server needed): |
bmbouter
added a commit
that referenced
this pull request
Apr 28, 2015
Updates metadata.json search to look in first top-level folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation was using a depth-first-search which did not
traverse in the same order on all platforms. Some Puppet modules
contain other modules as dependencies, and the DFS implementation
could incorrectly find the wrong one. This uses a very dumb
approach which looks for metadata.json in the top level folder
of the the tar.gz uploaded Puppet module. This is based on the
Puppet packaging guidelines 0.
https://pulp.plan.io/issues/890
closes #890