Don't ovewrite modules unless force flag is true #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daviddavis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jortel, @jeremycline and @schiermi to be potential reviewers. |
daviddavis
force-pushed
the
temp/20161213090658
branch
2 times, most recently
from
25b3a06
to
723fbde
Compare
daviddavis
changed the title
daviddavis
force-pushed
the
temp/20161213090658
branch
from
723fbde
to
91d4003
Compare
jortel
reviewed
Dec 15, 2016
| @@ -25,6 +25,8 @@ | |||
|
|
|||
| TAG = _('the name of a git tag to be checked out.') | |||
|
|
|||
| FORCE = _('overwrite modules in the output dir if true') | |||
There was a problem hiding this comment.
Using the word true here seems inappropriate since the user either includes the -f option or does not.
Suggest: overwrite modules in the output directory. instead.
jortel
approved these changes
Dec 15, 2016
daviddavis
force-pushed
the
temp/20161213090658
branch
from
91d4003
to
c887f24
Compare
By default, no longer overwriting modules in the output dir. Also, added a force flag which can override this behavior. fixes #1853 https://pulp.plan.io/issues/1853
daviddavis
force-pushed
the
temp/20161213090658
branch
from
c887f24
to
96945c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, no longer overwrite modules in the output dir. Also, added a force
flag which can override this behavior.
fixes #1853
https://pulp.plan.io/issues/1853