normalize project name before publish

closes #3632
https://pulp.plan.io/issues/3632

.pep8speaks.yml

@@ -0,0 +1,8 @@
+pycodestyle:
+    max-line-length: 100  # Default is 79 in PEP8
+    ignore:  # Errors and warnings to ignore
+        - E401 # multiple imports on one line
+    exclude:
+        - "./docs/*"
+        - "*/build/*"
+        - "*/migrations/*"

plugins/pulp_python/plugins/distributors/steps.py

@@ -11,6 +11,7 @@
 from pulp_python.common import constants
 from pulp_python.plugins import models
 from pulp_python.plugins.distributors import configuration
+from pulp_python.plugins.utils import sanitize_name
 
 
 logger = logging.getLogger(__name__)
@@ -92,6 +93,7 @@ def write_simple_api(self, projects):
             body = ElementTree.SubElement(html, 'body')
             # Create a reference in index.html that points to the index for each project.
             for project_name, packages in projects.items():
+                project_name = sanitize_name(project_name)
                 element = ElementTree.SubElement(body, 'a', {'href': project_name})
                 element.text = project_name
                 ElementTree.SubElement(body, 'br')
@@ -149,6 +151,7 @@ def write_json_api(self, projects):
         """
         api_path = os.path.join(self.parent.web_working_dir, 'pypi')
         for project_name, packages in projects.items():
+            project_name = sanitize_name(project_name)
             project_metadata_path = os.path.join(api_path, project_name, 'json')
             os.makedirs(project_metadata_path)
             project_index_metadata_path = os.path.join(project_metadata_path, 'index.json')

plugins/pulp_python/plugins/utils.py

@@ -0,0 +1,13 @@
+import re
+
+
+def sanitize_name(name):
+    """
+    Strips out all non-alphanumeric characters, including underscores, and replaces them with
+    hyphens. Runs of multiple non-alphanumeric characters are replaced by only one hyphen.
+    This is to take a given python package name and create an iteration of it that can be
+    used as part of a url, e.g. for the simple api.
+    Args:
+        name (str): A project name to sanitize
+    """
+    return re.sub('[^A-Za-z0-9]+', '-', name).lower()

plugins/test/unit/plugins/distributors/test_steps.py

@@ -158,7 +158,7 @@ def test_process_main(self, _create_project_index, makedirs, mock_package_qs, mo
         mock_package_qs.packages_by_project.assert_called_once_with(conduit.repo_id)
         makedirs.assert_has_calls([
             mock.call(os.path.join(step.parent.web_working_dir, 'simple')),
-            mock.call(os.path.join(step.parent.web_working_dir, 'pypi', 'pulp_python_plugins',
+            mock.call(os.path.join(step.parent.web_working_dir, 'pypi', 'pulp-python-plugins',
                                    'json')),
             mock.call(os.path.join(step.parent.web_working_dir, 'pypi', 'nectar', 'json')),
         ])