Bootstrap pulp_python plugin #116
Conversation
COPYRIGHT
Outdated
| @@ -1,4 +1,4 @@ | |||
| Copyright © 2014 Pulp Project developers. | |||
| Copyright © 2017 Pulp Project developers. | |||
There was a problem hiding this comment.
Would it be best to leave this at 2014? I don't think it matters one way or the other in this case
There was a problem hiding this comment.
I think this should be left as 2014:
The general rule is that the year to include in a copyright notice is the year of first publication of the work. [0]
COPYRIGHT
Outdated
| @@ -1,4 +1,4 @@ | |||
| Copyright © 2014 Pulp Project developers. | |||
| Copyright © 2017 Pulp Project developers. | |||
There was a problem hiding this comment.
I think this should be left as 2014:
The general rule is that the year to include in a copyright notice is the year of first publication of the work. [0]
docs/Makefile
Outdated
| @@ -1,153 +0,0 @@ | |||
| # Makefile for Sphinx documentation | |||
There was a problem hiding this comment.
I think eventually we're still planning on building sphinx docs. Although I am fine with this being deleted for now and bought back when we have sphinx docs to build.
docs/release-notes/1.0.rst
Outdated
| @@ -1,51 +0,0 @@ | |||
| 1.0 Release Notes | |||
There was a problem hiding this comment.
Same for these. I think we will need to bring the release notes back at some point, but it's fine if they go for now.
pulp_python/app/models.py
Outdated
| @@ -0,0 +1,84 @@ | |||
| """ | |||
There was a problem hiding this comment.
Can this doc string be removed?
pulp_python/app/serializers.py
Outdated
| @@ -0,0 +1,75 @@ | |||
| """ | |||
| Check `Plugin Writer's Guide`_ and `pulp_example`_ plugin | |||
There was a problem hiding this comment.
Can this doc string be removed?
pulp_python/app/viewsets.py
Outdated
| @@ -0,0 +1,53 @@ | |||
| """ | |||
| Check `Plugin Writer's Guide`_ and `pulp_example`_ plugin | |||
There was a problem hiding this comment.
Can this doc string also be removed?
flake8.cfg
Outdated
| @@ -1,5 +1,5 @@ | |||
| [flake8] | |||
| exclude = ./docs/* | |||
| exclude = */migrations/* | |||
There was a problem hiding this comment.
I think we should keep excluding docs
Replace current code with boilerplate created by plugin template. Added back README changes, AUTHORS, COPYRIGHT, travis.yaml, etc. closes: #2882 https://pulp.plan.io/issues/2882
Everything needed for getting the plugin to be installed properly by Pulp 3, and get basic CRUD functionality working.