Removed the ability to select md5, sha1, or sha224 as the checksum type

closes #2488

CHANGES/2488.removal

@@ -0,0 +1 @@
+Removed support for publishing repos with a checksum type of md5, sha1, or sha224

pulp_rpm/app/constants.py

@@ -13,11 +13,6 @@
 
 # The same as above, but in a format that choice fields can use
 CHECKSUM_CHOICES = (
-    (CHECKSUM_TYPES.UNKNOWN, CHECKSUM_TYPES.UNKNOWN),
-    (CHECKSUM_TYPES.MD5, CHECKSUM_TYPES.MD5),
-    (CHECKSUM_TYPES.SHA, CHECKSUM_TYPES.SHA1),
-    (CHECKSUM_TYPES.SHA1, CHECKSUM_TYPES.SHA1),
-    (CHECKSUM_TYPES.SHA224, CHECKSUM_TYPES.SHA224),
     (CHECKSUM_TYPES.SHA256, CHECKSUM_TYPES.SHA256),
     (CHECKSUM_TYPES.SHA384, CHECKSUM_TYPES.SHA384),
     (CHECKSUM_TYPES.SHA512, CHECKSUM_TYPES.SHA512),

pulp_rpm/app/migrations/0056_alter_package_checksum_type_and_more.py

@@ -0,0 +1,43 @@
+# Generated by Django 4.2.5 on 2023-11-06 22:58
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('rpm', '0055_add_repo_config_field'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='package',
+            name='checksum_type',
+            field=models.TextField(choices=[('sha256', 'sha256'), ('sha384', 'sha384'), ('sha512', 'sha512')]),
+        ),
+        migrations.AlterField(
+            model_name='repometadatafile',
+            name='checksum_type',
+            field=models.TextField(choices=[('sha256', 'sha256'), ('sha384', 'sha384'), ('sha512', 'sha512')]),
+        ),
+        migrations.AlterField(
+            model_name='rpmpublication',
+            name='metadata_checksum_type',
+            field=models.TextField(choices=[('sha256', 'sha256'), ('sha384', 'sha384'), ('sha512', 'sha512')]),
+        ),
+        migrations.AlterField(
+            model_name='rpmpublication',
+            name='package_checksum_type',
+            field=models.TextField(choices=[('sha256', 'sha256'), ('sha384', 'sha384'), ('sha512', 'sha512')]),
+        ),
+        migrations.AlterField(
+            model_name='rpmrepository',
+            name='metadata_checksum_type',
+            field=models.TextField(choices=[('sha256', 'sha256'), ('sha384', 'sha384'), ('sha512', 'sha512')], null=True),
+        ),
+        migrations.AlterField(
+            model_name='rpmrepository',
+            name='package_checksum_type',
+            field=models.TextField(choices=[('sha256', 'sha256'), ('sha384', 'sha384'), ('sha512', 'sha512')], null=True),
+        ),
+    ]

pulp_rpm/tests/functional/api/test_download_content.py

@@ -40,11 +40,6 @@ def test_all(
     2. Select a random content unit in the distribution. Download that
        content unit from Pulp, and verify that the content unit has the
        same checksum when fetched directly from Pulp-Fixtures.
-
-    This test targets the following issues:
-
-    * `Pulp #2895 <https://pulp.plan.io/issues/2895>`_
-    * `Pulp Smash #872 <https://github.com/pulp/pulp-smash/issues/872>`_
     """
     # Sync a Repository
     repo = rpm_unsigned_repo_immediate

pulp_rpm/tests/functional/api/test_download_policies.py

@@ -8,16 +8,6 @@
 from pulpcore.client.pulp_rpm import RpmRpmPublication
 
 
-"""Sync a repository with different download policies.
-
-This test targets the following issue:
-
-`Pulp #4126 <https://pulp.plan.io/issues/4126>`_
-`Pulp #4213 <https://pulp.plan.io/issues/4213>`_
-`Pulp #4418 <https://pulp.plan.io/issues/4418>`_
-"""
-
-
 @pytest.mark.parametrize("download_policy", DOWNLOAD_POLICIES)
 def test_download_policies(
     download_policy,

pulp_rpm/tests/functional/api/test_publish.py

@@ -663,14 +663,14 @@ def test_on_demand_specified_metadata_and_package_checksum_type(
 ):
     """Sync and publish an RPM repository and verify the checksum types."""
     repomd_checksum_types, primary_checksum_types = get_checksum_types(
-        package_checksum_type="sha224", metadata_checksum_type="sha224", policy="on_demand"
+        package_checksum_type="sha384", metadata_checksum_type="sha384", policy="on_demand"
     )
 
     for repomd_type, repomd_checksum_type in repomd_checksum_types.items():
-        assert repomd_checksum_type == "sha224"
+        assert repomd_checksum_type == "sha384"
 
     for package, package_checksum_type in primary_checksum_types.items():
-        # since none of the packages in question have sha224 checksums, the
+        # since none of the packages in question have sha384 checksums, the
         # checksums they do have will be used instead. In this case, sha256.
         assert package_checksum_type == "sha256"
 
@@ -707,14 +707,14 @@ def test_immediate_specified_metadata_checksum_type(get_checksum_types):
 def test_immediate_specified_metadata_and_package_checksum_type(get_checksum_types):
     """Sync and publish an RPM repository and verify the checksum types."""
     repomd_checksum_types, primary_checksum_types = get_checksum_types(
-        package_checksum_type="sha224", metadata_checksum_type="sha224", policy="immediate"
+        package_checksum_type="sha512", metadata_checksum_type="sha512", policy="immediate"
     )
 
     for repomd_type, repomd_checksum_type in repomd_checksum_types.items():
-        assert repomd_checksum_type == "sha224"
+        assert repomd_checksum_type == "sha512"
 
     for package, package_checksum_type in primary_checksum_types.items():
-        assert package_checksum_type == "sha224"
+        assert package_checksum_type == "sha512"
 
 
 @pytest.mark.parallel

pulp_rpm/tests/functional/api/test_pulp_to_pulp.py

@@ -32,8 +32,7 @@ def test_pulp_pulp_sync(
     # Create a publication.
     publish_data = RpmRpmPublication(
         repository=repo.pulp_href,
-        metadata_checksum_type="sha384",
-        package_checksum_type="sha224",
+        checksum_type="sha384",
     )
     publication = gen_object_with_cleanup(rpm_publication_api, publish_data)