Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether we can mitigate libmodulemd / metadata version compatibility issues in the future #2718

Closed
dralley opened this issue Aug 17, 2022 · 3 comments · Fixed by #2844
Closed

Investigate whether we can mitigate libmodulemd / metadata version compatibility issues in the future #2718

dralley opened this issue Aug 17, 2022 · 3 comments · Fixed by #2844
Assignees
@pavelpicka
Labels
prio-list Task

Comments

@dralley
Copy link
Contributor

dralley commented Aug 17, 2022

We currently have the issue that because our module yaml snippets go through libmodulemd before being saved, we are at the mercy of what libmodulemd does with them. In the past we have seen that when when individual modules contain metadata that the version of libmodulemd in question does not support, it silently?!? ignores the module during processing. This causes problems when creating associations between those modules and RPM packages.

We should investigate whether there are any better methods of storing this data such that the failures are not silent, or if we can make sure the correct thing happens independently of libmodulemd.
@dralley
Copy link
Contributor Author

dralley commented Sep 2, 2022

Action item: talk to ppisar, amatej

There is a strict=True mode which might help.

@dralley
Copy link
Contributor Author

dralley commented Sep 26, 2022

Another option: drop libmodulemd entirely perhaps

@pavelpicka pavelpicka self-assigned this Oct 4, 2022
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 5, 2022
@pavelpicka
Drop libmodulemd
1655cac 
use PyYaml instead to save snippets.

closes: pulp#2718
pulp#2718
@RCMariko
Copy link
Member

RCMariko commented Oct 7, 2022 •
edited

Another option: drop libmodulemd entirely perhaps

If we go this route, we might need to identify some product/downstream issues to be written for packaging/build teams.

pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 18, 2022
@pavelpicka
Drop libmodulemd
7e88625 
use PyYaml instead to save snippets.

* to write tests
* to update docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 18, 2022
@pavelpicka
Drop libmodulemd
7a81b90 
use PyYaml instead to save snippets.

* to write tests
* to update docs

closes: pulp#2718
pulp#2718
@pavelpicka pavelpicka mentioned this issue Oct 18, 2022
Merged
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 19, 2022
@pavelpicka
Drop libmodulemd
f32d8e4 
use PyYaml instead to save snippets.

* to write tests
* to update docs

* file parsing updated to split yaml document by ``---``
* few adjusts

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 24, 2022
@pavelpicka
Drop libmodulemd requirement
ad063b6 
use PyYaml instead to save and parse snippets.

* to write unit tests for date parsin
* to update docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 24, 2022
@pavelpicka
Modular tests
74f3491 
test if pulp populated modules.yaml are the same (not in order) as a
original modules.yaml

re: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 24, 2022
@pavelpicka
Modular tests
ad3c38b 
test if pulp populated modules.yaml are the same (not in order) as a
original modules.yaml

re: pulp#2718
pulp#2718
@pavelpicka pavelpicka mentioned this issue Oct 24, 2022
Closed
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 24, 2022
@pavelpicka
Modular tests
0e6ad4a 
test if pulp populated modules.yaml are the same (not in order) as a
original modules.yaml

re: pulp#2718
pulp#2718
[noissue]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Oct 24, 2022
@pavelpicka
Modular tests
9cf73b3 
test if pulp populated modules.yaml are the same (not in order) as a
original modules.yaml

re: pulp#2718
pulp#2718
[noissue]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 8, 2022
@pavelpicka
Drop libmodulemd requirement
500bc75 
use PyYaml instead to save and parse snippets.

* to write unit tests for date parsin
* to update docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 8, 2022
@pavelpicka
Drop libmodulemd requirement
45946ea 
use PyYaml instead to save and parse snippets.

* use textfield instead of dateandtime
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 8, 2022
@pavelpicka
Drop libmodulemd requirement
3ff2a3c 
use PyYaml instead to save and parse snippets.

* use textfield instead of dateandtime
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 8, 2022
@pavelpicka
Drop libmodulemd requirement
f0ea996 
use PyYaml instead to save and parse snippets.

* use textfield instead of dateandtime
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 18, 2022
@pavelpicka
Drop libmodulemd requirement
b966661 
use PyYaml instead to save and parse snippets.

* to write unit tests for date parsin
* to update docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 18, 2022
@pavelpicka
Drop libmodulemd requirement
dfe1369 
use PyYaml instead to save and parse snippets.

* use textfield instead of dateandtime
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 23, 2022
@pavelpicka
Drop libmodulemd requirement
ced186b 
use PyYaml instead to save and parse snippets.

* use textfield instead of dateandtime
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 23, 2022
@pavelpicka
Drop libmodulemd requirement
9eb3440 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 23, 2022
@pavelpicka
Drop libmodulemd requirement
327a4b8 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 24, 2022
@pavelpicka
Drop libmodulemd requirement
1ac5474 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 24, 2022
@pavelpicka
Drop libmodulemd requirement
7371d0b 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 29, 2022
@pavelpicka
Drop libmodulemd requirement
ccdf62e 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 29, 2022
@pavelpicka
Modular tests
b09aff3 
test if pulp populated modules.yaml are the same (not in order) as a
original modules.yaml

re: pulp#2718
pulp#2718
[noissue]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 29, 2022
@pavelpicka
Drop libmodulemd requirement
fab4688 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* removed `libmodulemd` from requirements in docs

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 30, 2022
@pavelpicka
Drop libmodulemd requirement
16c532b 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* removed `libmodulemd` from requirements in docs
* test that original and pulp generated modules.yaml are the same (not
  in order)

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Nov 30, 2022
@pavelpicka
Drop libmodulemd requirement
1babbd8 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* test that original and pulp generated modules.yaml are the same (not
  in order)

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Dec 5, 2022
@pavelpicka
Drop libmodulemd requirement
9f77ee4 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* test that original and pulp generated modules.yaml are the same (not
  in order)

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Dec 5, 2022
@pavelpicka
Drop libmodulemd requirement
4b5f512 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* test that original and pulp generated modules.yaml are the same (not
  in order)

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Dec 5, 2022
@pavelpicka
Drop libmodulemd requirement
f52e5f1 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* test that original and pulp generated modules.yaml are the same (not
  in order)

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Dec 5, 2022
@pavelpicka
Drop libmodulemd requirement
3a751f7 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* test that original and pulp generated modules.yaml are the same (not
  in order)

closes: pulp#2718
pulp#2718
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Dec 5, 2022
@pavelpicka
Drop libmodulemd requirement
3227fc4 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* test that original and pulp generated modules.yaml are the same (not
  in order)

closes: pulp#2718
pulp#2718
dralley pushed a commit that referenced this issue Dec 8, 2022
@pavelpicka @dralley
Drop libmodulemd requirement
99b90a6 
use PyYaml instead to save and parse snippets.

* use textfield instead of `DateTimeField`
* test that original and pulp generated modules.yaml are the same (not
  in order)

closes: #2718
#2718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavelpicka pavelpicka

Labels
prio-list Task
Projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop libmodulemd pavelpicka/pulp_rpm
3 participants
@dralley @RCMariko @pavelpicka