Stop using deepcopy in primary.xml processing to speed up sync #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The features introduced in pulp#1991 (https://pulp.plan.io/issues/1991) only act as filters based on whether or not a package is signed, and the short key ID of the key used to generate that signature. This changes any reference to "verification" introduced with those changes to "GPG Key ID filtering", and in general attempted to clarify that this is not a security feature, while still leaving it possible to (hopefully) do GPG package signature verification in a future version. fixes pulp#2188 https://pulp.plan.io/issues/2188
Tagging package [pulp-rpm] version [2.9.2-1] in directory [./].
The RPM rsync distributor uses SSH keys for authentication, and it must be told where to find a private key for authentication. This key must have certain permissions, or else SSH will refuse to use it. Update the documentation accordingly.
Clarify needed permissions for ssh_identity_file
Tagging package [pulp-rpm] version [2.10.1-1] in directory [./].
Fix ISO sync of already existing units
Tagging package [pulp-rpm] version [2.10.2-1] in directory [./].
|
@goosemania, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mhrivnak and @bmbouter to be potential reviewers. |
mhrivnak
approved these changes
Dec 5, 2016
dkliban
requested changes
Dec 6, 2016
| # NOTE the use of deepcopy relies on cpython's very sensible policy of never | ||
| # duplicating string literals, this may not hold up in other implementations | ||
| # the python interpreter. | ||
| rpm_entry = deepcopy(RPM_ENTRY_SKEL) |
There was a problem hiding this comment.
Is RPM_ENTRY_SKEL used anywhere else?
| # NOTE the use of deepcopy relies on cpython's very sensible policy of never | ||
| # duplicating string literals, this may not hold up in other implementations | ||
| # the python interpreter. | ||
| file_info = deepcopy(FILE_INFO_SKEL) |
There was a problem hiding this comment.
Is FILE_INFO_SKEL used anywhere else?
There was a problem hiding this comment.
Good point! The one which is used and has the same name comes from metedata.py, so this skeleton can be removed.
Tagging package [pulp-rpm] version [2.10.3-1] in directory [./].
|
As mentioned on IRC, you should rebase this against 2.10-dev and open a new PR |
|
Wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2466
https://pulp.plan.io/issues/2466