Fix non-utf8 when found in uploaded RPMs (really). #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uploading RPM packages with non-utf8 metadata, the upload was aborted. A fix already applied apparently did not fix this completely. Ensures that metadata from uploaded packages can be encoded to utf-8. Where no such encoding is possible, replacement chars are inserted. fixes pulp#1903 https://pulp.plan.io/issues/1903
|
Can one of the admins verify this patch? |
jortel
approved these changes
Mar 20, 2017
|
ok test |
|
The tests look good and it was approved so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading RPM packages with non-utf8 metadata, the upload was
aborted. A fix already applied apparently did not fix this completely.
Ensures that metadata from uploaded packages can be encoded to utf-8.
Where no such encoding is possible, replacement chars are inserted.
fixes #1903
https://pulp.plan.io/issues/1903