Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document modularity support #1086

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Document modularity support #1086

merged 1 commit into from
Mar 6, 2018

Conversation

dparalen
Copy link

Pulp_rpm supports the modularity content to the repo mirroring extent.

Fixes: #3353
https://pulp.plan.io/issues/3353

@pulpbot
Copy link
Member

pulpbot commented Feb 23, 2018

Can one of the admins verify this patch?

1 similar comment
@pulpbot
Copy link
Member

pulpbot commented Feb 23, 2018

Can one of the admins verify this patch?

Modularity
^^^^^^^^^^

Pulp supports modularity_ content use cases up to the `repository mirroring
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would suggest to explain here in docs( and not forcing the user to open and read the issue)in more details what do you mean by repository mirroring - as you already mentioned below that metadata is not processed maybe would be good to highlight also in which format/content type we store it in pulp rpm repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ina,

thanks for the review!
Yeah, I guess referring the reader to our issue tracker kinda sucks.
Lemme get back to this next week...

Cheers,
milan

:ref:`recipes`:

* synchronization of the modularity metadata content, the
``repodata/*modules.yaml.gz`` file, upon both the repository manual and
Copy link
Member

@ipanova ipanova Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by manual sync did you mean immediate?
other than that looks good to me, i could use a second pair or eyes of a native speaker though.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah immediate indeed, thanks! ;)

@dparalen dparalen force-pushed the issue_3353 branch 2 times, most recently from 49ae5a6 to 18b5e81 Compare March 6, 2018 14:38
Modularity
^^^^^^^^^^

Pulp supports following modularity_ repository mirroring use cases:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/following/the following/


* copy of the modularity metadata with the repository copy

* modules published thru Pulp are consumable by the ``dnf`` client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/thru/through/

Pulp supports following modularity_ repository mirroring use cases:

* synchronization of the modularity metadata content, the
``repodata/*modules.yaml.gz`` file, with either the repository immediate or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the repository//


* copy of the modularity metadata with the repository copy

* modules published thru Pulp are consumable by the ``dnf`` client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/thru/through/

* modules published thru Pulp are consumable by the ``dnf`` client

More advanced use cases are planned, especially those following from the ability
of Pulp processing the modularity metadata file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"More advanced use cases are planned, especially those dealing with the ability of Pulp to process modularity metadata files."


.. Note::

The metadata not being processed by Pulp it is possible for a consumer to
Copy link
Contributor

@daviddavis daviddavis Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad grammar here but not sure what's being said.

"In cases where the metadata is not being processed by Pulp, it is ..." maybe?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rephrasing to state that Pulp actually never processes modularity metadata

Copy link
Member

@goosemania goosemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the testing and a docs update 🎆


* modules published thru Pulp are consumable by the ``dnf`` client

More advanced use cases are planned, especially those following from the ability
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to exclude plans from the docs for now. It's not easy to keep it up to date. And it's not on our sprint yet.

@dparalen
Copy link
Author

dparalen commented Mar 6, 2018

Folks, thanks for the reviews! Update pending....
<3

Pulp_rpm supports the modularity content to the repo mirroring extent.

Fixes: pulp#3353
https://pulp.plan.io/issues/3353
@daviddavis daviddavis merged commit 7ceb641 into pulp:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants