-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document modularity support #1086
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
docs/user-guide/features.rst
Outdated
Modularity | ||
^^^^^^^^^^ | ||
|
||
Pulp supports modularity_ content use cases up to the `repository mirroring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would suggest to explain here in docs( and not forcing the user to open and read the issue)in more details what do you mean by repository mirroring
- as you already mentioned below that metadata is not processed maybe would be good to highlight also in which format/content type we store it in pulp rpm repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ina,
thanks for the review!
Yeah, I guess referring the reader to our issue tracker kinda sucks.
Lemme get back to this next week...
Cheers,
milan
docs/user-guide/features.rst
Outdated
:ref:`recipes`: | ||
|
||
* synchronization of the modularity metadata content, the | ||
``repodata/*modules.yaml.gz`` file, upon both the repository manual and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by manual sync did you mean immediate?
other than that looks good to me, i could use a second pair or eyes of a native speaker though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah immediate indeed, thanks! ;)
49ae5a6
to
18b5e81
Compare
docs/user-guide/features.rst
Outdated
Modularity | ||
^^^^^^^^^^ | ||
|
||
Pulp supports following modularity_ repository mirroring use cases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/following/the following/
docs/user-guide/features.rst
Outdated
|
||
* copy of the modularity metadata with the repository copy | ||
|
||
* modules published thru Pulp are consumable by the ``dnf`` client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/thru/through/
docs/user-guide/features.rst
Outdated
Pulp supports following modularity_ repository mirroring use cases: | ||
|
||
* synchronization of the modularity metadata content, the | ||
``repodata/*modules.yaml.gz`` file, with either the repository immediate or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/the repository//
docs/user-guide/features.rst
Outdated
|
||
* copy of the modularity metadata with the repository copy | ||
|
||
* modules published thru Pulp are consumable by the ``dnf`` client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/thru/through/
docs/user-guide/features.rst
Outdated
* modules published thru Pulp are consumable by the ``dnf`` client | ||
|
||
More advanced use cases are planned, especially those following from the ability | ||
of Pulp processing the modularity metadata file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"More advanced use cases are planned, especially those dealing with the ability of Pulp to process modularity metadata files."
docs/user-guide/features.rst
Outdated
|
||
.. Note:: | ||
|
||
The metadata not being processed by Pulp it is possible for a consumer to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad grammar here but not sure what's being said.
"In cases where the metadata is not being processed by Pulp, it is ..." maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rephrasing to state that Pulp actually never processes modularity metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the testing and a docs update 🎆
docs/user-guide/features.rst
Outdated
|
||
* modules published thru Pulp are consumable by the ``dnf`` client | ||
|
||
More advanced use cases are planned, especially those following from the ability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to exclude plans from the docs for now. It's not easy to keep it up to date. And it's not on our sprint yet.
Folks, thanks for the reviews! Update pending.... |
Pulp_rpm supports the modularity content to the repo mirroring extent. Fixes: pulp#3353 https://pulp.plan.io/issues/3353
Pulp_rpm supports the modularity content to the repo mirroring extent.
Fixes: #3353
https://pulp.plan.io/issues/3353