Weak deps migration #1151
Merged
Weak deps migration #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulp has been ignoring the Recommends weak dependency when processing e.g recursive unit copies. This patch updates the RPM model to track a recommends unit attribute and the primary.xml parser to populate this attribute. The libsolv dependency solver is used to process this attribute when calculating unit dependencies. Migration: populate the recommends attribute Walks over the rpm units, unzipping the primary metadata XML snippets, parsing the recommends entries and populating the recommends unit attributes accoridingly. Fixes: #3847 https://pulp.plan.io/issues/3847
Recommends field should be present on the model even if it is am empty list.
ipanova
force-pushed
the
weak-deps-migration
branch
from
a15e261
to
5277587
Compare
daviddavis
approved these changes
Aug 2, 2018
|
this PR needed some updates #1135 |
|
ok test |
3 similar comments
|
ok test |
|
ok test |
|
ok test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.