Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share solver between recursive associate calls #1156

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

dparalen
Copy link

@dparalen dparalen commented Aug 7, 2018

Currently each associate call in a recursive tree of calls instantiates
and loads its own instance of a solver. This is both CPU and RAM
expensive.

The fix avoids subsequent instantiation of the solver thru passing it as
an argument of the associate function.

Fixes: #3903

Currently each associate call in a recursive tree of calls instantiates
and loads its own instance of a solver. This is both CPU and RAM
expensive.

The fix avoids subsequent instantiation of the solver thru passing it as
an argument of the associate function.

Fixes: #3903
Copy link
Member

@ipanova ipanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specific example: if we happen to copy 10 package categories we'd end up to have 10 solvers in the memory instead of 1.
this pr is fixing mentioned behaviour.

@ipanova ipanova merged commit b99f97c into pulp:2-master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants