Fixing package upload #1284
Merged
Fixing package upload #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
issue4446
branch
from
5531330
to
4264602
Compare
Fixing package upload after changes from https://pulp.plan.io/issues/4394. fixes #4472 https://pulp.plan.io/issues/4472
daviddavis
force-pushed
the
issue4446
branch
from
4264602
to
060627d
Compare
daviddavis
commented
Feb 26, 2019
| help_text=_("File name of the package"), | ||
| required=False, | ||
| allow_null=True, | ||
| allow_blank=True, |
There was a problem hiding this comment.
This seems a bit odd to allow blank and null but it's required for backwards compatibility. See the related test.
goosemania
approved these changes
Feb 26, 2019
|
Merging. Travis failures are unrelated and under investigation. This fix being merge helps to eliminate false positives for other issues with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing package upload after changes from https://pulp.plan.io/issues/4394.
fixes #4472
https://pulp.plan.io/issues/4472