-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new RPMTAG_MODULARITYLABEL to identify modular RPMs #1368
Conversation
Old RPMTAG_DISTTAG is still in the code for the old content that might be still around. closes #4869 https://pulp.plan.io/issues/4869
|
||
# Id of the tag which is used to analyze RPM headers at upload or download time. | ||
# It's availiable in rpm package in F30+ and Centos8+. | ||
RPMTAG_MODULARITYLABEL = 5096 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind
This looks correct to me. Can I easily test this? |
Upload a modular rpm into Pulp and look at this content, its is_modular attribute should be set to True |
@dralley @goosemania I will be using the following fixture location. Mind seeing if the modular RPM I stole from Fedora works? This will later be updated to a generated fixture, but will suffice for initial verification. If this RPM is not Thanks! Edit: https://repos.fedorapeople.org/pulp/pulp/fixtures/rpm-with-modular/ |
@dralley @goosemania The PR for this test in If that is used and verified good, we can knock out two PR-birds with one PR-verification. I would appreciate knowing it if works with the new updates as well ;) PR Branch with Test |
@goosemania @pulp/qe I tested this manually and it works for me, but unfortunately I destroyed by vagrant box literally seconds before I saw this comment. |
@goosemania I ran the QE provided test for uploading an RPM and it failed. The sync test passed, but it passed prior to applying the patch also. It uses a different RPM. The RPM comes from here: https://repos.fedorapeople.org/repos/pulp/pulp/fixtures/rpm-with-modular/ I looked at the RPM headers with this command I got from the internet.
and it gave
so the tag is definitely there but maybe it doesn't match the regex |
@dralley , @bherrin3, I re-tested manually and I ran the test provided in pulp/Pulp-2-Tests#201 - it succeeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the failure was an environment problem.
Old RPMTAG_DISTTAG is still in the code for the old content
that might be still around.
closes #4869
https://pulp.plan.io/issues/4869