Use relative_path instead of filename #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
force-pushed
the
fix-filename-4987
branch
from
47d562e
to
e60e1f6
Compare
The field filename seems to be redundant. Therefore, it's usages were removed from the corresponding view set. Now, relative_path is used as filename instead. In this commit, the field relative_path is no longer nullable. Also, the field cannot be initialized to an empty string because it is used for a package creation where the path is stored as location_href. closes #4987 https://pulp.plan.io/issues/4987
lubosmj
force-pushed
the
fix-filename-4987
branch
from
e60e1f6
to
e7d624e
Compare
nixocio
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field filename seems to be redundant. Therefore, it's usages were removed from
the corresponding view set. Now, relative_path is used as filename instead.
In this commit, the field relative_path is no longer nullable. Also, the field
cannot be initialized to an empty string because it is used for a package creation
where the path is stored as location_href.
closes #4987
https://pulp.plan.io/issues/4987