Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync support for content types from comps.xml #1452

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

CodeHeeler
Copy link
Contributor

@CodeHeeler CodeHeeler commented Sep 25, 2019

Updates model relations, adds serializers, constants, viewsets,
libcomps parsing, and sync support for comps.xml content types

closes #5423
https://pulp.plan.io/issues/5423

@pep8speaks
Copy link

pep8speaks commented Sep 25, 2019

Hello @CodeHeeler! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-05 18:28:18 UTC

pulp_rpm/app/constants.py Outdated Show resolved Hide resolved
pulp_rpm/app/models.py Show resolved Hide resolved
pulp_rpm/app/models.py Outdated Show resolved Hide resolved
pulp_rpm/app/serializers.py Outdated Show resolved Hide resolved
pulp_rpm/app/viewsets.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
@CodeHeeler CodeHeeler force-pushed the issue-5423 branch 8 times, most recently from 3b3d5a1 to 8ec5133 Compare September 26, 2019 15:01
@CodeHeeler CodeHeeler changed the title WIP Add sync support for content types from comps.xml Add sync support for content types from comps.xml Sep 26, 2019
@dkliban
Copy link
Member

dkliban commented Sep 26, 2019

@CodeHeeler Do we need to update the setup.py to install any new python packages? Or is everything delivered through RPMs?

@CodeHeeler
Copy link
Contributor Author

@CodeHeeler Do we need to update the setup.py to install any new python packages? Or is everything delivered through RPMs?

No, I think everything is via RPMs.

pulp_rpm/app/models.py Outdated Show resolved Hide resolved
pulp_rpm/app/tasks/synchronizing.py Outdated Show resolved Hide resolved
pulp_rpm/app/models.py Outdated Show resolved Hide resolved
pulp_rpm/app/models.py Outdated Show resolved Hide resolved
pulp_rpm/app/models.py Outdated Show resolved Hide resolved
@CodeHeeler CodeHeeler requested a review from a team November 5, 2019 14:16
@CodeHeeler CodeHeeler force-pushed the issue-5423 branch 5 times, most recently from 498ce03 to ec0ed46 Compare November 5, 2019 16:28
pulp_rpm/app/models.py Outdated Show resolved Hide resolved
pulp_rpm/app/models.py Outdated Show resolved Hide resolved
pulp_rpm/app/models.py Outdated Show resolved Hide resolved
Updates model relations, adds serializers, constants, viewsets,
libcomps parsing, and sync support for comps.xml content types

closes #5423
https://pulp.plan.io/issues/5423
Copy link
Member

@goosemania goosemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@goosemania goosemania merged commit e1d73a0 into pulp:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants