Descriptive error for RPM with invalid metadata #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
force-pushed
the
4424
branch
2 times, most recently
from
6d1c751
to
8523457
Compare
daviddavis
suggested changes
Nov 21, 2019
pulp_rpm/app/tasks/synchronizing.py
Outdated
| missing_type = set(PACKAGE_REPODATA) - main_types | ||
| if missing_type: | ||
| raise FileNotFoundError(_("XML file(s): {filename} not found".format( | ||
| filename=", ".join(missing_type)))) |
There was a problem hiding this comment.
This needs to be _("XML file(s): {filename} not found").format(...)
daviddavis
reviewed
Nov 21, 2019
CHANGES/4424.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Providing a descriptive error message for RPM repos with invalid metadata | |||
There was a problem hiding this comment.
Probably not a misc changelog entry.
daviddavis
reviewed
Nov 21, 2019
pulp_rpm/app/tasks/synchronizing.py
Outdated
| try: | ||
| results = downloader.result() | ||
| except ClientResponseError as exc: | ||
| raise HTTPNotFound(reason=f"File not found: {exc.request_info.url}") |
There was a problem hiding this comment.
I think this needs to be internationalized, no?
daviddavis
reviewed
Nov 21, 2019
pulp_rpm/app/tasks/synchronizing.py
Outdated
| try: | ||
| results = downloader.result() | ||
| except ClientResponseError as exc: | ||
| raise HTTPNotFound(reason=_(f"File not found: {exc.request_info.url}")) |
There was a problem hiding this comment.
You can't use f strings and gettext as the string will be interpreted before it gets translated.
daviddavis
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/4424
closes #4424