923448 - made the changelog and filelist metadata migration more robust ... #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st in terms of handling non-utf8 text encoding
ghost
assigned 
| if not os.path.exists(pkg_path): | ||
| # if pkg doesnt exist, we cant get the pkg object, continue | ||
| return | ||
| po = yumbased.CreateRepoPackage(ts, pkg_path) |
There was a problem hiding this comment.
It would be nice to have a more descriptive name than "po" here.
There was a problem hiding this comment.
(I noticed that you didn't name that variable, but I also noticed that I hated its name :) )
There was a problem hiding this comment.
I have no idea what "po" or "ts" stand for.
There was a problem hiding this comment.
po is the convention yum uses for "package object"
ts is the convention for a rpm transaction object
|
Do what you will with my rambling comments, but it looks fine to me. Merge! |
mhrivnak
added a commit
that referenced
this pull request
Mar 21, 2013
923448 - made the changelog and filelist metadata migration more robust ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in terms of handling non-utf8 text encoding