Fixed copy to always include explicitly-requested packages. #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6519 |
dralley
reviewed
May 5, 2020
pulp_rpm/app/depsolving.py
Outdated
| @@ -838,7 +838,6 @@ def resolve_dependencies(self, unit_repo_map): | |||
| for unit in units: | |||
| if unit.pulp_type in {"rpm.package", "rpm.modulemd", "rpm.modulemd_defaults"}: | |||
| solvables.append(self.mapping.get_solvable(unit.pk, repo)) | |||
| else: | |||
| passthrough[repo].add(unit.pk) | |||
There was a problem hiding this comment.
I think this line needs to be de-indented to break it out of the conditional, otherwise content units like errata won't be "passed through"
There was a problem hiding this comment.
Oh ugh, concur - let me fix and do more testing
dralley
approved these changes
May 5, 2020
|
Apart from the failing style lints, lgtm |
Added a recursive-copy test to notice the problem. fixes #6519
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6519