Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature coverage list #1708

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

pavelpicka
Copy link
Contributor

@pavelpicka pavelpicka commented May 14, 2020

Simple markdown table of pulp_rpm feature coverage.
Travis hook to check if this file is updated.
With [nocoverage] in commit message this check can be skipped.

closes: #6706
https://pulp.plan.io/issues/6706

@pulpbot
Copy link
Member

pulpbot commented May 14, 2020

Attached issue: https://pulp.plan.io/issues/6706

@pavelpicka pavelpicka force-pushed the 6706-manual-coverage branch 11 times, most recently from af6af8d to bd6a368 Compare May 14, 2020 18:59
@pavelpicka pavelpicka changed the title [WIP] Feature coverage list Feature coverage list May 14, 2020
@pavelpicka pavelpicka changed the title Feature coverage list [WIP] Feature coverage list May 18, 2020
@pavelpicka pavelpicka force-pushed the 6706-manual-coverage branch 4 times, most recently from 2153e73 to 3d4181a Compare May 18, 2020 09:17
@pavelpicka pavelpicka changed the title [WIP] Feature coverage list Feature coverage list May 18, 2020
coverage.md Outdated Show resolved Hide resolved

if [[ $(git log --format=medium --no-merges "$RANGE" | grep "\[nocoverage\]") ]]
then
echo "[nocoverage] is present - skipping check"
Copy link
Member

@goosemania goosemania May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be s/check/the check/ but @daviddavis knows better.

@pavelpicka pavelpicka force-pushed the 6706-manual-coverage branch 2 times, most recently from d98f3b4 to 06b80f6 Compare May 18, 2020 11:19
Simple markdown table of pulp_rpm feature coverage.
Travis hook to check if this file is updated.
With [nocoverage] in commit message this check can be skipped.

closes: #6706
https://pulp.plan.io/issues/6706
Copy link
Contributor

@daviddavis daviddavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daviddavis daviddavis merged commit 80e8534 into pulp:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants