-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature coverage list #1708
Merged
Merged
Feature coverage list #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attached issue: https://pulp.plan.io/issues/6706 |
af6af8d
to
bd6a368
Compare
goosemania
reviewed
May 14, 2020
daviddavis
reviewed
May 14, 2020
daviddavis
reviewed
May 14, 2020
bd6a368
to
9037c60
Compare
2153e73
to
3d4181a
Compare
3d4181a
to
0922310
Compare
goosemania
reviewed
May 18, 2020
goosemania
reviewed
May 18, 2020
goosemania
reviewed
May 18, 2020
.travis/pre_before_install.sh
Outdated
|
||
if [[ $(git log --format=medium --no-merges "$RANGE" | grep "\[nocoverage\]") ]] | ||
then | ||
echo "[nocoverage] is present - skipping check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be s/check/the check/ but @daviddavis knows better.
d98f3b4
to
06b80f6
Compare
Simple markdown table of pulp_rpm feature coverage. Travis hook to check if this file is updated. With [nocoverage] in commit message this check can be skipped. closes: #6706 https://pulp.plan.io/issues/6706
06b80f6
to
c318b12
Compare
daviddavis
approved these changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple markdown table of pulp_rpm feature coverage.
Travis hook to check if this file is updated.
With
[nocoverage]
in commit message this check can be skipped.closes: #6706
https://pulp.plan.io/issues/6706