Fix borked migration between 3.3.0 and 3.3.1+ schema. #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
commented
May 14, 2020
| @@ -13,6 +13,6 @@ class Migration(migrations.Migration): | |||
| migrations.AlterField( | |||
| model_name='rpmrepository', | |||
| name='last_sync_revision_number', | |||
| field=models.CharField(max_length=20, null=True), | |||
| field=models.CharField(max_length=20), | |||
There was a problem hiding this comment.
It seems to work without re-modifying 0005, I think because null=False by default. Should I modify 0005 anyway?
There was a problem hiding this comment.
Oh, I'm not sure, but I'd remove from 0005 as well. Less flipping it back and forth, and 0005 will be in it's original state.
|
Attached issue: https://pulp.plan.io/issues/6743 |
goosemania
approved these changes
May 14, 2020
|
I tested this w/ the following scenarios:
|
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6743
https://pulp.plan.io/issues/6743