Move tests to new kickstart fixture #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7040 |
daviddavis
force-pushed
the
issue7040
branch
2 times, most recently
from
41e0302
to
7e93daa
Compare
daviddavis
changed the title
daviddavis
force-pushed
the
issue7040
branch
2 times, most recently
from
7baddec
to
bf1a047
Compare
daviddavis
commented
Aug 29, 2020
| RPM_PACKAGECATEGORY_CONTENT_NAME: 1, | ||
| RPM_PACKAGEENVIRONMENT_CONTENT_NAME: 1, | ||
| RPM_PACKAGEGROUP_CONTENT_NAME: 1, | ||
| RPM_PACKAGELANGPACKS_CONTENT_NAME: 1, |
There was a problem hiding this comment.
I decided to not make these integers constants since they don't need to be used elsewhere. Happy to reconsider if anyone disagrees.
|
Tests are failing as I need to add code to cleanup content. Setting to draft. |
daviddavis
force-pushed
the
issue7040
branch
2 times, most recently
from
2a9fb7f
to
fc7466c
Compare
|
I found the cause of these test failures. Turns out orphan cleanup is not removing kickstart content. I filed a bug: https://pulp.plan.io/issues/7440 |
This was referenced Sep 14, 2020
fixes #7040 [nocoverage]
daviddavis
force-pushed
the
issue7040
branch
2 times, most recently
from
18d9ee5
to
7b58262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7040