Sync through proxy fix #1837
Merged
Sync through proxy fix #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7321 |
goosemania
reviewed
Sep 4, 2020
pulp_rpm/app/downloaders.py
Outdated
| @@ -84,7 +84,7 @@ async def _run(self, extra_data=None): | |||
| else: | |||
| url = self.url | |||
|
|
|||
| async with self.session.get(url) as response: | |||
| async with self.session.get(url, proxy=self.proxy, proxy_auth=self.proxy_auth) as response: | |||
There was a problem hiding this comment.
I see that in the core we pass auth and not proxy_auth. https://github.com/pulp/pulpcore/blob/master/pulpcore/download/http.py#L209
I'm not familiar enough to say which one is right. Should both be passed? so if proxy is set, then proxy_auth is used?
There was a problem hiding this comment.
I am not sure about auth, as I followed aiohttp docs https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support
There was a problem hiding this comment.
we don't use proxy_auth alone, so changing as in the core for basic http authentication
Fix sync using proxy server. Custom downloader doesn't passed proxy info. [nocoverage] closes: #7321 https://pulp.plan.io/issues/7321
pavelpicka
force-pushed
the
7321-proxy-download
branch
from
04d68e2
to
c717196
Compare
goosemania
approved these changes
Sep 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sync using proxy server.
Custom downloader doesn't passed proxy info.
[nocoverage]
closes: #7321
https://pulp.plan.io/issues/7321