Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution tree tests #1860

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Distribution tree tests #1860

merged 1 commit into from
Oct 22, 2020

Conversation

pavelpicka
Copy link
Contributor

Sync test:
update main repo of DT
update addon repo of DT
update variant repo DT
remove repository with DT, and orphan cleanup to remove DT

Copy test:
simple copy of DT
copy DT by content specified

closes: #7571
https://pulp.plan.io/issues/7571

@pep8speaks
Copy link

pep8speaks commented Sep 25, 2020

Hello @pavelpicka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-20 15:45:56 UTC

@pulpbot
Copy link
Member

pulpbot commented Sep 25, 2020

Attached issue: https://pulp.plan.io/issues/7571

@pavelpicka pavelpicka force-pushed the dt-tests branch 2 times, most recently from 615707c to bc5ee6e Compare September 25, 2020 17:26
@@ -1215,3 +1220,164 @@ def test_all(self):
RPM_FIXTURE_SUMMARY,
get_content_summary(repo.to_dict())
)


class DistributionTreeTest(PulpTestCase):
Copy link
Contributor

@daviddavis daviddavis Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestion here but may want to break out these distribution tests into a separate distribution_tree.py file since test_sync.py and test_copy.py are getting incredibly long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it is good idea, so moving test to test_distribution_tree.py

@daviddavis
Copy link
Contributor

This is looking good 👍

Sync test:
update main repo of DT
update addon repo of DT
update variant repo DT
remove repository with DT, and orphan cleanup to remove DT

Copy test:
simple copy of DT
copy DT by content specified

[nocoverage]
closes: #7571
https://pulp.plan.io/issues/7571
@ggainey ggainey merged commit 4b3e539 into pulp:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants