Make gpgpcheck options to be a non-required parameter #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Issue #6926 is not at NEW/ASSIGNED/POST. |
goosemania
reviewed
Oct 23, 2020
| @@ -250,7 +250,7 @@ def get_checksum_type(name, checksum_types): | |||
| return getattr(cr, checksum_type.upper(), cr.SHA256) | |||
|
|
|||
|
|
|||
| def publish(repository_version_pk, gpgcheck_options, metadata_signing_service=None, | |||
| def publish(repository_version_pk, gpgcheck_options=None, metadata_signing_service=None, | |||
There was a problem hiding this comment.
It helps the migration plugin to stay compatible with older versions of pulp_rpm.
goosemania
approved these changes
Oct 23, 2020
lubosmj
force-pushed
the
fix-required-gpgcheck-publish-t
branch
from
4e6630f
to
fe8d20d
Compare
ref #6926 [nocoverage]
lubosmj
force-pushed
the
fix-required-gpgcheck-publish-t
branch
from
fe8d20d
to
2e0c745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6926