Teach pulp_rpm to only use urljoin() where it really needs urljoin(). #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggainey
force-pushed
the
urljoin_replace
branch
from
1d40f58
to
d2c49dc
Compare
|
Attached issue: https://pulp.plan.io/issues/7995 |
dralley
reviewed
Mar 16, 2021
dralley
reviewed
Mar 16, 2021
dralley
approved these changes
Mar 16, 2021
* Added shared_utils.urlpath_sanitize() to fill the niche that urljoin() was being (incorrectly) used for. * Added unit-tests for shared_util. * Fixed a problem with shared_utils.is_previous_version() that unit-tests exposed. fixes #7995
ggainey
force-pushed
the
urljoin_replace
branch
from
d2c49dc
to
fa14b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was being (incorrectly) used for.