-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong checksum being used for publication #1976
Conversation
95529ed
to
92bdfb9
Compare
Attached issue: https://pulp.plan.io/issues/8644 |
@goosemania This is unrelated to auto-publish, it was introduced when we fixed the "sha" checksum issue. |
pulp_rpm/app/tasks/publishing.py
Outdated
checksum_type = metadata | ||
|
||
return getattr(cr, getattr(CHECKSUM_TYPES, checksum_type.upper()), cr.SHA256) | ||
return getattr(cr, getattr(CHECKSUM_TYPES, checksum_type.upper()).upper(), cr.SHA256) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# "sha" -> "SHA" -> "CHECKSUM_TYPES.SHA" -> "sha1" | ||
normalized_checksum_type = getattr(CHECKSUM_TYPES, checksum_type.upper()) | ||
# "sha1" -> "SHA1" -> "cr.SHA1" | ||
return getattr(cr, normalized_checksum_type.upper()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
closes: #8644
https://pulp.plan.io/issues/8644