Fix syncs from file:// repos and add a test #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/9021 Attached issue: https://pulp.plan.io/issues/7350 |
ggainey
requested changes
Jul 6, 2021
There was a problem hiding this comment.
Can we add a "Required PR:" for pulp/pulpcore#1463 as well?
| @@ -128,6 +128,29 @@ def test_sync(self): | |||
| self.assertEqual(latest_version_href, repo.latest_version_href) | |||
| self.assertDictEqual(get_content_summary(repo.to_dict()), RPM_FIXTURE_SUMMARY) | |||
|
|
|||
| def test_sync_local(self): | |||
ianballou
reviewed
Jul 6, 2021
nm, that PR has been merged so we should be good. |
ggainey
approved these changes
Jul 6, 2021
ggainey
requested changes
Jul 6, 2021
|
|
||
| remote = self.remote_api.create(gen_rpm_remote(url="file:///tmp/rpm-unsigned/")) | ||
|
|
||
| self.do_test(remote=remote, mirror=True) |
There was a problem hiding this comment.
Missing cleanup - see
pulp_rpm/pulp_rpm/tests/functional/api/test_sync.py
Lines 116 to 119 in d87b377
closes: #9021 https://pulp.plan.io/issues/9021 closes: #7350 https://pulp.plan.io/issues/7350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9021
https://pulp.plan.io/issues/9021
closes: #7350
https://pulp.plan.io/issues/7350