Adopt new "shared_resources" / "exclusive_resources" API #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/9255 |
mdellweg
reviewed
Aug 26, 2021
pulp_rpm/app/viewsets.py
Outdated
| @@ -137,7 +137,7 @@ def sync(self, request, pk): | |||
|
|
|||
| result = dispatch( | |||
| tasks.synchronize, | |||
| [repository, remote], | |||
| exclusive_resources=[repository, remote], | |||
There was a problem hiding this comment.
I believe, the remote might be shared here.
mdellweg
reviewed
Aug 26, 2021
| @@ -328,7 +333,8 @@ def _process_config(self, config): | |||
| dest_repo = NamedModelViewSet().get_resource(entry["dest_repo"], RpmRepository) | |||
| r["source_repo_version"] = source_version.pk | |||
| r["dest_repo"] = dest_repo.pk | |||
| repos.extend((source_version.repository, dest_repo)) | |||
| shared_repos.append(source_version.repository) | |||
| exclusive_repos.append(dest_repo) | |||
|
Do you want to flip the flag in the CI to actually trigger this? |
|
@mdellweg I think so - but maybe in a followup PR so that we can unblock the installer |
ggainey
approved these changes
Aug 26, 2021
mdellweg
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9255
https://pulp.plan.io/issues/9255