950772 - Don't attempt state transitions away from STATE_CANCELLED. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,7 +87,7 @@ def build_final_report(self): | |||
| summary = self.build_progress_report() | |||
| details = None | |||
|
|
|||
| if self.state == self.STATE_COMPLETE: | |||
| if self.state in (self.STATE_COMPLETE, self.STATE_CANCELLED): | |||
There was a problem hiding this comment.
Consider STATE_CANCELLED to be a "successful" state.
ghost
assigned 
| manifest = models.ISOManifest(manifest_destiny, self._repo_url) | ||
| except ValueError, e: | ||
| self.progress_report.error_message = 'The PULP_MANIFEST file was not in the ' +\ | ||
| 'expected format.' |
There was a problem hiding this comment.
If this is intended to be shown to a user, make sure to run it through gettext.
|
Two things to take a look at, afterwards merge on. |
|
I merged this one into the 2.2.1 branch, and into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the third comment in the bug[0], where it failed QE.
[0] https://bugzilla.redhat.com/show_bug.cgi?id=950772#c3