Add Domain support.

[ggainey]

closes #3008

(cherry picked from commit 67067318fecf83e0bbe471739b052a1668c893df)
Co-authored by: Grant Gainey ggainey@redhat.com

[ggainey]

This is very draft - pushing it up to make it possible to have eyes on it when/if/as I run into problems.

[gerrod3]

Not sure if you need any changes in the task code as well. If they use queries then they probably need a filter by task domain.

[ggainey]

Not sure if you need any changes in the task code as well. If they use queries then they probably need a filter by task domain.

Almost certainly - it's next on The List...

[ggainey]

Tests that check content-access will fail until pulp/pulpcore#3748 gets merged.

[ggainey]

OK folks - for the moment this is still in draft, but I need eyes, because I've looked at these files for Too Long. The tests all pass in both domain-on and domain-off mode. Improvements for the tests/fixtures very gratefully accepted, I based what I'm doing on pulp_file's work, but RPM is Different (and so is my brain).

@gerrod3 I am Absurdly Positive I have missed something Important - let me know if you think of/see anything.

[dralley]

Looking reasonable so far, I'll take a deeper dive tomorrow

[gerrod3]

Looking good, this is close to being ready. What do you think about for adding docs?

[gerrod3]

@ggainey Have you gone over this checklist: https://docs.pulpproject.org/pulpcore/plugin_dev/plugin-writer/concepts/domains/domains_compatibility.html

I think some of the task code might still need to be looked over and more importantly you need to update the template_config.yml to activate domain testing in the CI.

[gerrod3]

Implementation looks good! Some questions on the tests.

[ggainey]

pulp-cli test failures:
test_rpm_sync_publish fails because it does this:
expect_succ curl "$curl_opt" --head --fail "$PULP_BASE_URL/pulp/content/cli_test_rpm_distro/config.repo"
which fails in domain-enabled environs. It should be using the distribution's base-url (or possibly being domain-aware and inserting domain-name when needed, but that feels overly complex). Getting this test to pass requires a fix and a pulp-cli release, and I propose it shouldn't hold up this PR merging into pulp_rpm.

The acs failure, I can't yet explain. All the tests end with "success" (start here ), it feels like cleanup() is what's triggering a failure here. Thoughts anyone?

[gerrod3]

The acs failure, I can't yet explain. All the tests end with "success" (start here ), it feels like cleanup() is what's triggering a failure here. Thoughts anyone?

The acs test fails due to the grep -E expression not matching since domain is now in the url: https://github.com/pulp/pulp-cli/blob/main/tests/scripts/pulp_rpm/test_acs.sh#L41. Going to have to add some checks for domains or use a more lenient expression like pulp_file: https://github.com/pulp/pulp-cli/blob/main/tests/scripts/pulp_file/test_acs.sh#L41

[ggainey]

The acs failure, I can't yet explain. All the tests end with "success" (start here ), it feels like cleanup() is what's triggering a failure here. Thoughts anyone?

The acs test fails due to the grep -E expression not matching since domain is now in the url: https://github.com/pulp/pulp-cli/blob/main/tests/scripts/pulp_rpm/test_acs.sh#L41. Going to have to add some checks for domains or use a more lenient expression like pulp_file: https://github.com/pulp/pulp-cli/blob/main/tests/scripts/pulp_file/test_acs.sh#L41

Ah yes, exactly so, thanks @gerrod3 .

OK - so my proposal is, we allow these failures for this PR. I will work on fixing pulp-cli, which will need a release before pulp_rpm PRs will stop noticing these failures. As long as we recognize that they're test-bugs, not rpm-domain-bugs, and are ok with seeing them for a few days, I think we can accept this PR.

Assuming nobody thinks of Something Else...

[ggainey]

Test-failures are addressed in this PR

[ggainey]

With the release of pulp-cli/0.19.2, the test failures were addressed and this PR is now green. Can has merge please? kthxbai