1026907 - Fix dep equality comparison when a release is omitted. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -318,16 +318,26 @@ def test___eq___true(self): | |||
| """ | |||
| Test the __eq__ method with equal Requirements. | |||
| """ | |||
| r_1 = depsolve.Requirement('test', 0, '1.0.01') | |||
There was a problem hiding this comment.
This got me thinking. I think this was the only test we had that ensured, somewhat indirectly, that "x.01" == "x.1". That also made me realize that this PR has changed that behavior, so that they are no longer equal, where before they were. Perhaps we should serialize the versions before doing the equality comparison? In any case, there should be a test that ensures the correct behavior when a leading zero is involved.
$ rpmdev-vercmp
Epoch1:
Version1: 1.2.3
Release1:
Epoch2:
Version2: 1.2.03
Release2:
1.2.3 == 1.2.03
|
LGTM |
jdob
pushed a commit
that referenced
this pull request
Nov 7, 2013
1026907 - Fix dep equality comparison when a release is omitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1026907