1042932 - Fix listings files in export distributor for both individual r... #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l repos and repo groups.
| # build iso and publish via HTTPS | ||
| self._publish_isos(repo, config, progress_callback) | ||
| else: | ||
| export_dir = config.get(constants.EXPORT_DIRECTORY_KEYWORD) | ||
| util.generate_listing_files(export_dir, self.working_dir) |
There was a problem hiding this comment.
Is that call to _publish_isos not necessary in this branch of the if statement?
There was a problem hiding this comment.
No, if an export directory is specified we export the expanded form of the repository and not the ISO.
|
If you can just add a test asserting that listing file is excluded (and comment explaining why we want to exclude it), LGTM. Oh, and please do remove the unit test from that doc block. Is that what your fancy IDEs do these days? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...epos and repo groups.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1042932